* WT-2661: Coverity failures: 1356050-1356053 CID 1356050: (NULL_RETURNS) Dereferencing a pointer that might be null "opts->home" when calling "snprintf". CID 1356050: (NULL_RETURNS) Dereferencing a pointer that might be null "opts->uri" when calling "snprintf". * Assigning address of auto variable '_opts' to static (it's an auto variable in main(), so it's safe, but make lint happy). * Coverity appears to be confused by argv handling and eventually passing NULL to snprintf. 2. var_assign_alias: Assigning: opts->progname = argv[0]. Both are now tainted. 47. vararg_transitive: Call to snprintf with tainted argument opts->progname taints NULL. 48. tainted_data_sink_lv_call: Passing tainted variable 0UL to tainted data sink snprintf. NULL is tainted? I'm hoping that using a strlen() call to figure out the string length instead of snprintf() will make this one go away. * test_wt2246_col_append wasn't actually doing any work, set nrecords to a 20 million default. * KNF * Don't use "inline" in example programs, it requires Windows #ifdef's.
133 lines
3.9 KiB
C
133 lines
3.9 KiB
C
/*-
|
|
* Public Domain 2014-2016 MongoDB, Inc.
|
|
* Public Domain 2008-2014 WiredTiger, Inc.
|
|
*
|
|
* This is free and unencumbered software released into the public domain.
|
|
*
|
|
* Anyone is free to copy, modify, publish, use, compile, sell, or
|
|
* distribute this software, either in source code form or as a compiled
|
|
* binary, for any purpose, commercial or non-commercial, and by any
|
|
* means.
|
|
*
|
|
* In jurisdictions that recognize copyright laws, the author or authors
|
|
* of this software dedicate any and all copyright interest in the
|
|
* software to the public domain. We make this dedication for the benefit
|
|
* of the public at large and to the detriment of our heirs and
|
|
* successors. We intend this dedication to be an overt act of
|
|
* relinquishment in perpetuity of all present and future rights to this
|
|
* software under copyright law.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
|
|
* IN NO EVENT SHALL THE AUTHORS BE LIABLE FOR ANY CLAIM, DAMAGES OR
|
|
* OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
|
|
* ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*/
|
|
#include "test_util.h"
|
|
|
|
extern int __wt_opterr; /* if error message should be printed */
|
|
extern int __wt_optind; /* index into parent argv vector */
|
|
extern int __wt_optopt; /* character checked for validity */
|
|
extern int __wt_optreset; /* reset getopt */
|
|
extern char *__wt_optarg; /* argument associated with option */
|
|
|
|
/*
|
|
* testutil_parse_opts --
|
|
* Parse command line options for a test case.
|
|
*/
|
|
int
|
|
testutil_parse_opts(int argc, char * const *argv, TEST_OPTS *opts)
|
|
{
|
|
int ch;
|
|
size_t len;
|
|
|
|
opts->preserve = false;
|
|
opts->running = true;
|
|
opts->verbose = false;
|
|
|
|
if ((opts->progname = strrchr(argv[0], '/')) == NULL)
|
|
opts->progname = argv[0];
|
|
else
|
|
++opts->progname;
|
|
|
|
while ((ch = __wt_getopt(opts->progname,
|
|
argc, argv, "A:h:n:o:pR:T:t:vW:")) != EOF)
|
|
switch (ch) {
|
|
case 'A': /* Number of append threads */
|
|
opts->n_append_threads = (uint64_t)atoll(__wt_optarg);
|
|
break;
|
|
case 'h': /* Home directory */
|
|
opts->home = __wt_optarg;
|
|
break;
|
|
case 'n': /* Number of records */
|
|
opts->nrecords = (uint64_t)atoll(__wt_optarg);
|
|
break;
|
|
case 'o': /* Number of operations */
|
|
opts->nops = (uint64_t)atoll(__wt_optarg);
|
|
break;
|
|
case 'p': /* Preserve directory contents */
|
|
opts->preserve = true;
|
|
break;
|
|
case 'R': /* Number of reader threads */
|
|
opts->n_read_threads = (uint64_t)atoll(__wt_optarg);
|
|
break;
|
|
case 'T': /* Number of threads */
|
|
opts->nthreads = (uint64_t)atoll(__wt_optarg);
|
|
break;
|
|
case 't': /* Table type */
|
|
switch (__wt_optarg[0]) {
|
|
case 'C':
|
|
case 'c':
|
|
opts->table_type = TABLE_COL;
|
|
break;
|
|
case 'F':
|
|
case 'f':
|
|
opts->table_type = TABLE_FIX;
|
|
break;
|
|
case 'R':
|
|
case 'r':
|
|
opts->table_type = TABLE_ROW;
|
|
break;
|
|
}
|
|
break;
|
|
case 'v':
|
|
opts->verbose = true;
|
|
break;
|
|
case 'W': /* Number of writer threads */
|
|
opts->n_write_threads = (uint64_t)atoll(__wt_optarg);
|
|
break;
|
|
case '?':
|
|
default:
|
|
(void)fprintf(stderr, "usage: %s "
|
|
"[-A append thread count] "
|
|
"[-h home] "
|
|
"[-n record count] "
|
|
"[-o op count] "
|
|
"[-p] "
|
|
"[-R read thread count] "
|
|
"[-T thread count] "
|
|
"[-t c|f|r table type] "
|
|
"[-v] "
|
|
"[-W write thread count] ",
|
|
opts->progname);
|
|
return (1);
|
|
}
|
|
|
|
/*
|
|
* Setup the home directory. It needs to be unique for every test
|
|
* or the auto make parallel tester gets upset.
|
|
*/
|
|
len = strlen("WT_TEST.") + strlen(opts->progname) + 10;
|
|
opts->home = dmalloc(len);
|
|
snprintf(opts->home, len, "WT_TEST.%s", opts->progname);
|
|
|
|
/* Setup the default URI string */
|
|
len = strlen("table:") + strlen(opts->progname) + 10;
|
|
opts->uri = dmalloc(len);
|
|
snprintf(opts->uri, len, "table:%s", opts->progname);
|
|
|
|
return (0);
|
|
}
|