eebc418c22
Tests should, generally, not be accessing global const values like kReplDefaultTimeoutMS. This change removes that const and fixes the detect_spawning_own_mongod.js override so that it no longer overwrites ReplSetTest.kDefaultTimeoutMS, making it accessible to jstests that do not operate on replica sets.
43 lines
1.9 KiB
JavaScript
43 lines
1.9 KiB
JavaScript
/**
|
|
* Define overrides to prevent any test from spawning its own test fixture since certain passthrough
|
|
* suites should not contain JS tests that start their own mongod/s.
|
|
*/
|
|
(function() {
|
|
'use strict';
|
|
|
|
MongoRunner.runMongod = function() {
|
|
throw new Error(
|
|
"Detected MongoRunner.runMongod() call in js test from passthrough suite. " +
|
|
"Consider moving the test to one of the jstests/noPassthrough/, " +
|
|
"jstests/replsets/, or jstests/sharding/ directories.");
|
|
};
|
|
|
|
MongoRunner.runMongos = function() {
|
|
throw new Error(
|
|
"Detected MongoRunner.runMongos() call in js test from passthrough suite. " +
|
|
"Consider moving the test to one of the jstests/noPassthrough/, " +
|
|
"jstests/replsets/, or jstests/sharding/ directories.");
|
|
};
|
|
|
|
const STOverrideConstructor = function() {
|
|
throw new Error("Detected ShardingTest() call in js test from passthrough suite. " +
|
|
"Consider moving the test to one of the jstests/noPassthrough/, " +
|
|
"jstests/replsets/, or jstests/sharding/ directories.");
|
|
};
|
|
|
|
// This Object.assign() lets us modify ShardingTest to use the new overridden constructor but
|
|
// still keep any static properties it has.
|
|
ShardingTest = Object.assign(STOverrideConstructor, ShardingTest);
|
|
|
|
const RSTOverrideConstructor = function() {
|
|
throw new Error("Detected ReplSetTest() call in js test from passthrough suite. " +
|
|
"Consider moving the test to one of the jstests/noPassthrough/, " +
|
|
"jstests/replsets/, or jstests/sharding/ directories.");
|
|
};
|
|
|
|
// Same as the above Object.assign() call. In particular, we want to preserve the
|
|
// ReplSetTest.kDefaultTimeoutMS property, which should be accessible to tests in the
|
|
// passthrough suite.
|
|
ReplSetTest = Object.assign(RSTOverrideConstructor, ReplSetTest);
|
|
})();
|