xuemingqiang/mongo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

do not allow _id scans on capped collections SERVER-3064

Browse Source
This commit is contained in:
Eliot Horowitz
2011-08-05 11:43:09 -04:00
parent f6896afc92
commit 72db2c4197
2 changed files with 44 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
db/queryoptimizer.cpp
View File

@@ -211,8 +211,19 @@ doneCheckOrder:
}
if ( willScanTable() ) {
if ( _frs.nNontrivialRanges() )
if ( _frs.nNontrivialRanges() ) {
checkTableScanAllowed( _frs.ns() );
// if we are doing a table scan on _id
// and its a capped collection
// we disallow as its a common user error
// .system. and local collections are exempt
if ( _d && _d->capped && _frs.range( "_id" ).nontrivial() ) {
uassert( 14820, "doing _id query on a capped collection without an index is not allowed" ,
str::contains( _frs.ns() , ".system." ) ||
str::startsWith( _frs.ns() , "local." ) );
}
}
return findTableScan( _frs.ns(), _order, startLoc );
}