xuemingqiang/mongo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

SERVER-470 MINOR don't need persistent handles for copied function arguments

Browse Source
This commit is contained in:
Aaron
2009-12-29 19:26:54 -08:00
parent c1d105d076
commit 3b84e7162e
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
scripting/v8_utils.cpp
View File

@@ -204,13 +204,10 @@ namespace mongo {
fun = config_.f_;
}
Context::Scope context_scope( context );
// TODO maybe we can get away with local handles here
boost::scoped_array< Persistent< Value > > argv( new Persistent< Value >[ config_.args_.size() ] );
boost::scoped_array< Local< Value > > argv( new Local< Value >[ config_.args_.size() ] );
for( unsigned int i = 0; i < config_.args_.size(); ++i )
argv[ i ] = Persistent< Value >::New( config_.args_[ i ] );
argv[ i ] = Local< Value >::New( config_.args_[ i ] );
Local< Value > ret = fun->Call( context->Global(), config_.args_.size(), argv.get() );
for( unsigned int i = 0; i < config_.args_.size(); ++i )
argv[ i ].Dispose();
config_.returnData_ = Persistent< Value >::New( ret );
}
private: