Use StateValue constants instead of raw value

This commit is contained in:
Haoyu Qiu
2017-10-20 23:58:52 +08:00
parent 77b8450f80
commit d50565f859
2 changed files with 12 additions and 12 deletions

View File

@ -411,17 +411,17 @@ class AppDelegate: NSObject, NSApplicationDelegate, NSUserNotificationCenterDele
serversMenuItem.title = serverMenuText serversMenuItem.title = serverMenuText
if mode == "auto" { if mode == "auto" {
autoModeMenuItem.state = NSControl.StateValue(rawValue: 1) autoModeMenuItem.state = .on
globalModeMenuItem.state = NSControl.StateValue(rawValue: 0) globalModeMenuItem.state = .off
manualModeMenuItem.state = NSControl.StateValue(rawValue: 0) manualModeMenuItem.state = .off
} else if mode == "global" { } else if mode == "global" {
autoModeMenuItem.state = NSControl.StateValue(rawValue: 0) autoModeMenuItem.state = .off
globalModeMenuItem.state = NSControl.StateValue(rawValue: 1) globalModeMenuItem.state = .on
manualModeMenuItem.state = NSControl.StateValue(rawValue: 0) manualModeMenuItem.state = .off
} else if mode == "manual" { } else if mode == "manual" {
autoModeMenuItem.state = NSControl.StateValue(rawValue: 0) autoModeMenuItem.state = .off
globalModeMenuItem.state = NSControl.StateValue(rawValue: 0) globalModeMenuItem.state = .off
manualModeMenuItem.state = NSControl.StateValue(rawValue: 1) manualModeMenuItem.state = .on
} }
updateStatusMenuImage() updateStatusMenuImage()
} }
@ -493,7 +493,7 @@ class AppDelegate: NSObject, NSApplicationDelegate, NSUserNotificationCenterDele
let item = NSMenuItem() let item = NSMenuItem()
item.tag = i + kProfileMenuItemIndexBase item.tag = i + kProfileMenuItemIndexBase
item.title = profile.title() item.title = profile.title()
item.state = NSControl.StateValue(rawValue: (mgr.activeProfileId == profile.uuid) ? 1 : 0) item.state = (mgr.activeProfileId == profile.uuid) ? .on : .off
item.isEnabled = profile.isValid() item.isEnabled = profile.isValid()
item.action = #selector(AppDelegate.selectServer) item.action = #selector(AppDelegate.selectServer)

View File

@ -48,9 +48,9 @@ class ProxyInterfacesViewCtrl: NSViewController, NSTableViewDataSource, NSTableV
let networkService = networkServices[row] as! [String: Any] let networkService = networkServices[row] as! [String: Any]
let key = networkService["key"] as! String let key = networkService["key"] as! String
if selectedNetworkServices.contains(key) { if selectedNetworkServices.contains(key) {
cell.state = NSControl.StateValue(rawValue: 1) cell.state = .on
} else { } else {
cell.state = NSControl.StateValue(rawValue: 0) cell.state = .off
} }
let userDefinedName = networkService["userDefinedName"] as! String let userDefinedName = networkService["userDefinedName"] as! String
cell.title = userDefinedName cell.title = userDefinedName